Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update deps & fix benchmarks #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Update deps & fix benchmarks #2239

merged 1 commit into from
Oct 23, 2024

Conversation

Finistere
Copy link
Member

@Finistere Finistere commented Oct 22, 2024 •
edited
Loading

We're fixing dependency versions quite strictly for a reason that escapes me. We miss updates like this one: serde-rs/json#1206. So relaxed a few of those. And fixed the benchmarks now that we're using spawn_blocking inside the engine

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Federation Audit Report170 ran107 passed0 skipped63 failed

@Finistere Finistere marked this pull request as ready for review October 23, 2024 07:43
@Finistere Finistere requested a review from a team as a code owner October 23, 2024 07:43
@Finistere Finistere requested review from pimeys and removed request for a team October 23, 2024 07:43
@pimeys pimeys mentioned this pull request Oct 23, 2024
Closed
jakubadamw
jakubadamw reviewed Oct 23, 2024
View reviewed changes
@Finistere Finistere force-pushed the coordinator-futures branch from 4d3d3b4 to 4230c43 Compare October 23, 2024 09:21
Base automatically changed from coordinator-futures to main October 23, 2024 09:34
@Finistere Finistere force-pushed the brabier-update-dependencies branch from 3f5e833 to ac3a3d8 Compare October 23, 2024 09:44
@Finistere Finistere merged commit 16c1402 into main Oct 23, 2024
19 checks passed
@Finistere Finistere deleted the brabier-update-dependencies branch October 23, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbjork fbjork fbjork approved these changes

@pimeys pimeys pimeys approved these changes

+1 more reviewer

@jakubadamw jakubadamw jakubadamw left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Finistere @fbjork @pimeys @jakubadamw