Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

grafbase-ci
Copy link
Collaborator

This PR contains the following updates:

Package Type Update Change
httpsig workspace.dependencies patch 0.0.18 -> 0.0.19

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2025-59058

Summary

HMAC signature comparison is not timing-safe and is vulnerable to timing attacks.

Details

SharedKey::sign() returns a Vec<u8> which has a non-constant-time equality implementation.

Hmac::finalize() returns a constant-time wrapper (CtOutput) which was discarded. Alternatively, Hmac has a constant-time verify() method.

The problem reported here is due to the following lines in SharedKey::sign() of the previous code:

let mut mac = HmacSha256::new_from_slice(key).unwrap();
mac.update(data);
Ok(mac.finalize().into_bytes().to_vec())

and the merged update changes the third line to directly verify with verify_slice.

Impact

Anyone who uses HS256 signature verification is vulnerably to Timing Attack that allows the attacker to forge a signature.


Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@grafbase-ci grafbase-ci added the dependencies Pull requests that update a dependency file label Sep 12, 2025
@grafbase-ci
Copy link
Collaborator Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package [email protected] --precise 0.0.19
    Updating crates.io index
error: failed to select a version for the requirement `httpsig = "^0.0.18"`
candidate versions found which didn't match: 0.0.19
location searched: crates.io index
required by package `httpsig-hyper v0.0.18`
    ... which satisfies dependency `httpsig-hyper = "^0.0.18"` (locked to 0.0.18) of package `runtime-local v0.1.0 (/tmp/renovate/repos/github/grafbase/grafbase/crates/runtime-local)`
    ... which satisfies path dependency `runtime-local` (locked to 0.1.0) of package `grafbase v0.102.4 (/tmp/renovate/repos/github/grafbase/grafbase/cli)`

Copy link

TestsPassed ❌️SkippedFailed
Federation Audit Report0 ran0 passed0 skipped0 failed

@fbjork fbjork enabled auto-merge September 13, 2025 09:46
@pimeys
Copy link
Contributor

pimeys commented Sep 15, 2025

Updated here #3503

@pimeys pimeys closed this Sep 15, 2025
auto-merge was automatically disabled September 15, 2025 14:17

Pull request was closed

@grafbase-ci grafbase-ci deleted the renovate/crate-httpsig-vulnerability branch September 15, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

4 participants