⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (0c6f35f) to head (a4bf720).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          18       18           
  Lines         840      840           
  Branches       52       52           
=======================================
  Hits          767      767           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for spark 4.0 we need java 17 and 21

for spark 4.0 we need java 17 and 21

Okay, I will test again but this seemed to break Java 8, so I thought of pulling it. I will check again.

I do not have any idea what is required for Spark 4. If you have a better grasp, I would mucho appreciate a Spark 4 support ticket :)

@bjornjorgensen yeah this breaks Java 0.8, which I think most Spark users run. I guess we should conditionally add it based on the JVM version?

Unrecognized option: --add-opens=java.base/sun.nio.ch=ALL-UNNAMED

Spark also includes -XX:+IgnoreUnrecognizedVMOptions so it works for both Java versions

spark branch 3.5 only support and build on java version 11 and 17
https://github.com/apache/spark/actions/runs/12743044791/job/35512274672

I have with a lot of help from AI tested it to run on java 8, 11 and 17 https://github.com/bjornjorgensen/graphframes/commits/java11/ you can copy what you like but.. its made just to test and it is written by AI