Merged
Conversation
Contributor
Author
|
@rjurney can you have a look |
Collaborator
Hey, yeah I'll test this today. |
Collaborator
|
@bjornjorgensen I meant today :D Okay, this works for me on Java 8 and 11 and passes all tests... once I |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving the codebase by ensuring consistency in the use of
toIndexedSeqandtoSeqmethods, along with some minor refactoring. The most important changes include updates to theGraphFrameclass and related objects, as well as updates to other classes and objects within thegraphframespackage.Improvements to
GraphFrameclass and related objects:src/main/scala/org/graphframes/GraphFrame.scala: Modified thetoStringmethod to usetoIndexedSeqandtoSeqfor column selection consistency.src/main/scala/org/graphframes/GraphFrame.scala: UpdatedfromEdgesmethod to usedistinct()instead ofdistinct.src/main/scala/org/graphframes/GraphFrame.scala: UpdatedcolStarandnestAsColmethods to usetoIndexedSeqandtoSeqrespectively. [1] [2]Refactoring in other classes and objects:
src/main/scala/org/graphframes/examples/BeliefPropagation.scala: Ensured consistent use oftoIntconversion aftercount()method inrunBPwithGraphXandrunBPwithGraphFramesmethods. [1] [2]src/main/scala/org/graphframes/examples/Graphs.scala: UpdatedALSSyntheticDatamethod to usetoIndexedSeqfor data and vertices.src/main/scala/org/graphframes/lib/BFS.scala: Modifiedpaths.selectto usetoSeqfor column selection.src/main/scala/org/graphframes/lib/GraphXConversions.scala: Updatedselectmethod to usetoSeqfor field selection.src/main/scala/org/graphframes/lib/ShortestPaths.scala: Replacedscala.collection.JavaConverterswithscala.jdk.CollectionConverters.src/main/scala/org/graphframes/lib/ShortestPaths.scala: Updatedselectmethod to usetoSeqfor column selection.src/main/scala/org/graphframes/lib/TriangleCount.scala: Modifiedselectmethod to usetoSeqfor column selection.This removes warnings when we build. Note we can't use WrappedArray if we will have support for Scala 2.12