What changes were proposed in this pull request? 1. A new mixin WithMaxIter to avoid code duplication 2. Propagate maxIter to GraphX-based implementation of ConnectedComponents Why are the changes needed? As described in issue. Close #419 <#419> cc: @Ishitori <https://github.com/Ishitori> cc: @SauronShepherd <https://github.com/SauronShepherd> could you take a look too? ------------------------------ You can view, comment on, or merge this pull request online at: #590 Commit Summary - 0886b9c <0886b9c> Add a new mixin WithMaxIter and propogate it to GraphX CC File Changes (6 files <https://github.com/graphframes/graphframes/pull/590/files>) - *M* src/main/scala/org/graphframes/lib/ConnectedComponents.scala <https://github.com/graphframes/graphframes/pull/590/files#diff-f8d47cdb6a1b97658e89673c2c756a8eaff3707cc2036e501343b7b1d0b13467> (16) - *M* src/main/scala/org/graphframes/lib/LabelPropagation.scala <https://github.com/graphframes/graphframes/pull/590/files#diff-68c13ae73a2fc5984d57eff5cd3c7ff68b46809dcbc41a6b6e60299bb7c99738> (16) - *M* src/main/scala/org/graphframes/lib/ParallelPersonalizedPageRank.scala <https://github.com/graphframes/graphframes/pull/590/files#diff-7ffd88ca6f9ea07607021e48109aa815017b6c49f140d78fa9371eaddd7d7e26> (11) - *M* src/main/scala/org/graphframes/lib/SVDPlusPlus.scala <https://github.com/graphframes/graphframes/pull/590/files#diff-f427cdda2bf88f1d01f72b2bd26f0fd13e07ddb1468f0bdf2662c5a9ec374d80> (13) - *M* src/main/scala/org/graphframes/lib/StronglyConnectedComponents.scala <https://github.com/graphframes/graphframes/pull/590/files#diff-729b9d9c541d3f8026a77f7da6c0199b05a95b08dd982adccb6fe6aeb6402d3c> (11) - *M* src/main/scala/org/graphframes/mixins.scala <https://github.com/graphframes/graphframes/pull/590/files#diff-bd137ca2c3f150adc7eb2e15a82f698f084f2a498e331e82feb8b530a9455223> (12) Patch Links: - https://github.com/graphframes/graphframes/pull/590.patch - https://github.com/graphframes/graphframes/pull/590.diff — Reply to this email directly, view it on GitHub <#590>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCN67ZEQ3SOX5VUAXJESIL22JP2RAVCNFSM6AAAAAB3OUSLUKVHI2DSMVQWIX3LMV43ASLTON2WKOZTGAYDMNBXG42TOOA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

I thought we weren't going to invert time into GraphX anymore. I spent about 15 minutes for it :) I would like to close as much issues as possible (#559 <#559>). This one (#419 <#419>) was trivial, just couple of lines of real code. Plus I added a MixIn as part of #560 <#560>. Does it sound OK to accept this fix? @SauronShepherd <https://github.com/SauronShepherd> — Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCN67YGKORVZMW5QZVHF5L22JRYVAVCNFSM6AAAAAB3OUSLUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWG42DMNRYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***> *SemyonSinchenko* left a comment (graphframes/graphframes#590) <#590 (comment)> I thought we weren't going to invert time into GraphX anymore. I spent about 15 minutes for it :) I would like to close as much issues as possible (#559 <#559>). This one (#419 <#419>) was trivial, just couple of lines of real code. Plus I added a MixIn as part of #560 <#560>. Does it sound OK to accept this fix? @SauronShepherd <https://github.com/SauronShepherd> — Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCN67YGKORVZMW5QZVHF5L22JRYVAVCNFSM6AAAAAB3OUSLUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWG42DMNRYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>