⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (06ee372) to head (54c9d98).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (06ee372) and HEAD (54c9d98). Click for more details.

HEAD has 3 uploads less than BASE

Flag	BASE (06ee372)	HEAD (54c9d98)
	4	1

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   87.82%   80.74%   -7.08%     
==========================================
  Files          22       24       +2     
  Lines        1092     1184      +92     
  Branches      124      148      +24     
==========================================
- Hits          959      956       -3     
- Misses        133      228      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@james-willis I think it is my fault, I was going to work on the docs about how to contribute to the spark-connect plugin but as always I failed due to limited time...

tldr:

1. U need to update the protobuf message here: https://github.com/graphframes/graphframes/blob/master/graphframes-connect/src/main/protobuf/graphframes.proto#L62
2. U need to update the plugin util here: https://github.com/graphframes/graphframes/blob/master/graphframes-connect/src/main/scala/org/apache/spark/sql/graphframes/GraphFramesConnectUtils.scala#L99
3. U need to re-generate python files from protobuf:
   • install buf: https://buf.build/docs/cli/installation/
   • run buf generate from the root of the project

Or just add it to the core and I will do all the corresponding updates of PySpark APIs (both classic and connect)

Surely this time is the charm!

my local python tests aren't set up so I've been using the CI as a test platform.