fix: remove version.sbt#637
Merged
SemyonSinchenko merged 1 commit intographframes:masterfrom Jul 17, 2025
Merged
Conversation
Collaborator
Author
|
From the CI logs (Python CI): [info] Built: /home/runner/work/graphframes/graphframes/graphframes-connect/target/scala-2.13/graphframes-connect-spark4_2.13-0.0.0+1-9996b40f-SNAPSHOT-spark4.0.jarAs you can see, the version is automatically generated by the plugin based on the github tags. The only reason version is 0.0.0 here is because to get the full git history and tags information. It is specified in publishing CI, but it is not needed for testing. I also tested it locally and it works fine: sbt:graphframes> publishLocal
[info] Wrote /var/home/sem/github/graphframes/target/scala-2.12/graphframes-spark3_2.12-0.9.0+1-f554aaf9-SNAPSHOT-spark3.5.pomwhere So, long story short, it works. |
Collaborator
|
How do snapshots work now? |
james-willis
approved these changes
Jul 17, 2025
Collaborator
Author
In the same way except the commit hash is added to the version string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
version.sbtsbt-ci-release correctly determines the version without this file. Otherwise the release-CI is not working at all, see #635
Why are the changes needed?
Close #635