Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: resolve gf-connect is not published#645

Merged
SemyonSinchenko merged 11 commits intographframes:masterfrom
SemyonSinchenko:639-fix-connect-publishing
Jul 17, 2025
Merged

fix: resolve gf-connect is not published#645
SemyonSinchenko merged 11 commits intographframes:masterfrom
SemyonSinchenko:639-fix-connect-publishing

Conversation

@SemyonSinchenko
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko commented Jul 17, 2025

What changes were proposed in this pull request?

Refactoring according the comment

Why are the changes needed?

Close #639

@SemyonSinchenko SemyonSinchenko changed the title 639 fix connect publishing fix: resolve gf-connect is not published Jul 17, 2025
@SemyonSinchenko SemyonSinchenko self-assigned this Jul 17, 2025
@SemyonSinchenko
Copy link
Collaborator Author

SemyonSinchenko commented Jul 17, 2025

Thanks @Kimahriman for the suggestion! I tried publishLocal and it works as expected!

Kimahriman
Kimahriman reviewed Jul 17, 2025
View reviewed changes
Kimahriman
Kimahriman reviewed Jul 17, 2025
View reviewed changes
@Kimahriman
Copy link
Contributor

Kimahriman commented Jul 17, 2025

IMO it would be cleaner to just have core/ and connect/ folders, instead of having both prefixed with graphframes-, but up to you

Kimahriman
Kimahriman reviewed Jul 17, 2025
View reviewed changes
@Kimahriman
Copy link
Contributor

Kimahriman commented Jul 17, 2025

One last other thing I noticed. The Spark 3 build is built with Java 11, but Spark 3 does support Java 8 so the released artifacts should be built with Java 8

@SemyonSinchenko
Copy link
Collaborator Author

SemyonSinchenko commented Jul 17, 2025

And again thanks a lot @Kimahriman ! Your experience is helping a lot to GraphFarmes to become better!!

@SemyonSinchenko
Copy link
Collaborator Author

SemyonSinchenko commented Jul 17, 2025

I will update

rjurney
rjurney approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@rjurney rjurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like core got left out previously?

@rjurney
Copy link
Collaborator

rjurney commented Jul 17, 2025

Oh wait, CI failed...

Kimahriman
Kimahriman reviewed Jul 17, 2025
View reviewed changes
@SemyonSinchenko
Copy link
Collaborator Author

SemyonSinchenko commented Jul 17, 2025

lgtm, looks like core got left out previously?

@Kimahriman resolved the puzzle (see comments in the issue). Mostly it was my fault, I was needed to refactor it to the right multi-project sbt layout when I introduced connect.

@SemyonSinchenko SemyonSinchenko merged commit 7c5ae09 into graphframes:master Jul 17, 2025
5 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 639-fix-connect-publishing branch July 17, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjurney rjurney rjurney approved these changes

@james-willis james-willis Awaiting requested review from james-willis

+1 more reviewer

@Kimahriman Kimahriman Kimahriman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@SemyonSinchenko SemyonSinchenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: graphframes-connect is not published

3 participants

@SemyonSinchenko @Kimahriman @rjurney