feat: updates in SBT and new site engine#673
Merged
SemyonSinchenko merged 19 commits intographframes:masterfrom Sep 9, 2025
Merged
feat: updates in SBT and new site engine#673SemyonSinchenko merged 19 commits intographframes:masterfrom
SemyonSinchenko merged 19 commits intographframes:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 78.21% 81.62% +3.40%
==========================================
Files 29 28 -1
Lines 1368 1306 -62
Branches 167 148 -19
==========================================
- Hits 1070 1066 -4
+ Misses 298 240 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
How to test it?
|
james-willis
reviewed
Sep 2, 2025
benchmarks/src/main/scala/org/graphframes/benchmarks/LDBCBenchmarkSuite.scala
Outdated
Show resolved
Hide resolved
james-willis
reviewed
Sep 2, 2025
benchmarks/src/main/scala/org/graphframes/benchmarks/LDBCBenchmarkSuite.scala
Show resolved
Hide resolved
james-willis
reviewed
Sep 2, 2025
james-willis
reviewed
Sep 2, 2025
james-willis
requested changes
Sep 2, 2025
rjurney
approved these changes
Sep 4, 2025
|
|
||
| val moviesGroup = VertexPropertyGroup("movies", moviesData, "id", applyMaskOnId = false) | ||
| ``` | ||
|
|
Collaborator
There was a problem hiding this comment.
This is called graph construction via deconvolution. Maybe worth using the term "deconvolution." Search for "deconvolution" in this PDF from Stanford CS224W in 2018: https://snap.stanford.edu/class/cs224w-2018/handouts/04-netconstruct.pdf for more info.
6 tasks
Collaborator
Author
|
I fixed all the tests, benchmarks, etc.
|
Collaborator
Author
|
@rjurney @james-willis take another look please |
james-willis
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Close #672
Features: