Codestin Search App

goungoun · 2025-10-09T10:21:43Z

What changes were proposed in this pull request?

This PR improves the formatting for the variable-length and undirected motif pattern.

Add informative columns: _hop, _pattern, _direction
Fix the first column name change for a variable-length pattern
The first edge column name for the fixed pattern (u)-[e*1]-(v) and the variable length pattern should be _e1, not e, so that it matches with the other column.

Case 1: undirected pattern
g.find("(u)-[]-(v)").where("u.id == 0").show()

Before:
It took me quite some time to understand why it returns two rows, not three rows. The bidirectional edge returns one with the anonymous edge pattern.

+---------+---------+
|        u|        v|  
+---------+---------+
|{0, a, f}|{1, b, m}|
|{0, a, f}|{2, c, m}|
+---------+---------+

After:
It returns three rows with the information, two in edges and one out edge.

+---------+---------+-----------+----------+
|        u|        v|   _pattern|_direction|
+---------+---------+-----------+----------+
|{0, a, f}|{1, b, m}|(u)<-[]-(v)|        in|
|{0, a, f}|{2, c, m}|(u)<-[]-(v)|        in|
|{0, a, f}|{1, b, m}|(u)-[]->(v)|       out|
+---------+---------+-----------+----------+

Case 2: undirected variable-length pattern
g.find("(v)-[e*1..3]-(u)").where("u.id == 2").show()

Before:
Cannot understand why e column is placed at the end of the data frame, and not easy to understand the result.

+---------+---------------+---------+--------------+---------+--------------+---------+---------------+
|        u|            _e1|      _v1|           _e2|      _v2|           _e3|        v|              e|
+---------+---------------+---------+--------------+---------+--------------+---------+---------------+
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 2, friend}|{2, c, m}|           NULL|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 0, follow}|{0, a, f}|           NULL|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|     NULL|          NULL|{1, b, m}|           NULL|
|{2, c, m}|           NULL|     NULL|          NULL|     NULL|          NULL|{3, d, f}| {2, 3, follow}|
|{2, c, m}|           NULL|     NULL|          NULL|     NULL|          NULL|{0, a, f}|{2, 0, unknown}|
|{2, c, m}| {1, 0, follow}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 2, friend}|{1, b, m}|           NULL|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 2, friend}|{2, c, m}|           NULL|
|{2, c, m}| {0, 1, friend}|{1, b, m}|{1, 2, friend}|     NULL|          NULL|{0, a, f}|           NULL|
|{2, c, m}|           NULL|     NULL|          NULL|     NULL|          NULL|{1, b, m}| {1, 2, friend}|
+---------+---------------+---------+--------------+---------+--------------+---------+---------------+

After:
The informative columns such as _hop, _pattern, _direction is added to help understand the results. It also ordered by _hop, _direction.

+---------+---------------+---------+--------------+---------+--------------+---------+----+--------------+----------+
|        u|            _e1|      _v1|           _e2|      _v2|           _e3|        v|_hop|      _pattern|_direction|
+---------+---------------+---------+--------------+---------+--------------+---------+----+--------------+----------+
|{2, c, m}| {1, 2, friend}|     NULL|          NULL|     NULL|          NULL|{1, b, m}|   1|(u)<-[e*1]-(v)|        in|
|{2, c, m}| {2, 3, follow}|     NULL|          NULL|     NULL|          NULL|{3, d, f}|   1|(u)-[e*1]->(v)|       out|
|{2, c, m}|{2, 0, unknown}|     NULL|          NULL|     NULL|          NULL|{0, a, f}|   1|(u)-[e*1]->(v)|       out|
|{2, c, m}| {0, 1, friend}|{1, b, m}|{1, 2, friend}|     NULL|          NULL|{0, a, f}|   2|(u)<-[e*2]-(v)|        in|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|     NULL|          NULL|{1, b, m}|   2|(u)-[e*2]->(v)|       out|
|{2, c, m}| {1, 0, follow}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 2, friend}|{1, b, m}|   3|(u)<-[e*3]-(v)|        in|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 2, friend}|{2, c, m}|   3|(u)<-[e*3]-(v)|        in|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 2, friend}|{2, c, m}|   3|(u)-[e*3]->(v)|       out|
|{2, c, m}|{2, 0, unknown}|{0, a, f}|{0, 1, friend}|{1, b, m}|{1, 0, follow}|{0, a, f}|   3|(u)-[e*3]->(v)|       out|
+---------+---------------+---------+--------------+---------+--------------+---------+----+--------------+----------+

goungoun · 2025-10-09T12:30:15Z

Now, it make sense to me. Please merge this improvement before releasing the new version.
@SemyonSinchenko and @rjurney, I am waiting for your review. :)

SemyonSinchenko

Thanks for this @goungoun

goungoun · 2025-10-11T14:58:33Z

While checking the examples in the manual, I found a bug and fixed. The named edge pattern (u)<-[e]->(v) should be transformed to (u)-[e1]->(v);(v)-[e2]->(u). (u)-[e]->(v);(v)-[e]->(u) is wrong.

goungoun · 2025-10-11T16:06:12Z

@SemyonSinchenko, I pushed the document changes, 04-motif-finding.md.

SemyonSinchenko

Nice! Thanks @goungoun

goungoun · 2025-10-12T12:44:36Z

Thank you, @SemyonSinchenko.

goungoun added 2 commits October 9, 2025 19:16

add informative columns

a320046

change first edge name for varlength pattern

e2a9ad7

goungoun changed the title ~~Improve result formatting for variable length pattern and undirected pattern~~ [WIP] Improve result formatting for variable length pattern and undirected pattern Oct 9, 2025

goungoun added 3 commits October 9, 2025 19:57

udpate test case

423dd57

sbt scalafmtAll

912ad8d

order undirected pattern

266964f

goungoun changed the title ~~[WIP] Improve result formatting for variable length pattern and undirected pattern~~ Improve result formatting for variable length pattern and undirected pattern Oct 9, 2025

goungoun marked this pull request as ready for review October 9, 2025 12:20

SemyonSinchenko approved these changes Oct 9, 2025

View reviewed changes

SemyonSinchenko mentioned this pull request Oct 9, 2025

feat: prepare the release 0.10.0 #725

Merged

bug fix - bidirectional named edge pattern

4f98f23

doc

95e091b

docs - add undirectional pattern and fix patterns

df0d8d7

goungoun requested a review from SemyonSinchenko October 12, 2025 04:10

SemyonSinchenko approved these changes Oct 12, 2025

View reviewed changes

SemyonSinchenko merged commit f5de10f into graphframes:main Oct 12, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve result formatting for variable length pattern and undirected pattern#728

Improve result formatting for variable length pattern and undirected pattern#728
SemyonSinchenko merged 8 commits intographframes:mainfrom
goungoun:informative

goungoun commented Oct 9, 2025 •

edited

Loading

Uh oh!

goungoun commented Oct 9, 2025 •

edited

Loading

Uh oh!

SemyonSinchenko left a comment

Uh oh!

goungoun commented Oct 11, 2025

Uh oh!

goungoun commented Oct 11, 2025

Uh oh!

SemyonSinchenko left a comment

Uh oh!

Uh oh!

goungoun commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

goungoun commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Uh oh!

goungoun commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SemyonSinchenko left a comment

Choose a reason for hiding this comment

Uh oh!

goungoun commented Oct 11, 2025

Uh oh!

goungoun commented Oct 11, 2025

Uh oh!

SemyonSinchenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

goungoun commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

goungoun commented Oct 9, 2025 •

edited

Loading

goungoun commented Oct 9, 2025 •

edited

Loading