Replace specialized firehose_triggers_in_block by direct usage of TriggerAdapter::triggers_in_blocks`
#3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
maoueh/feature/async-stream-firehose-block-stream
to
master
December 17, 2021 19:59
…TriggerAdapter::triggers_in_blocks` With the revamped `FirehoseBlockStream`, it's now possible to directly re-use the `TriggerAdapter::triggers_in_blocks` code instead of relying on our specialized `firehose_triggers_in_block`. This make the code more re-usable. Eliminated at the same time a useless close in `NearChair::TriggersAdapter`. Also make some `NearChain` now panics instead of silently returning something that is not good. Linked to #3080
e687fde to
34a4295
Compare
leoyvens
approved these changes
Dec 17, 2021
kamilkisiela
pushed a commit
that referenced
this pull request
Jan 5, 2022
…TriggerAdapter::triggers_in_blocks` (#3082) With the revamped `FirehoseBlockStream`, it's now possible to directly re-use the `TriggerAdapter::triggers_in_blocks` code instead of relying on our specialized `firehose_triggers_in_block`. This make the code more re-usable. Eliminated at the same time a useless close in `NearChair::TriggersAdapter`. Also make some `NearChain` now panics instead of silently returning something that is not good. Linked to #3080 Co-authored-by: Matthieu Vachon <[email protected]>
kamilkisiela
pushed a commit
that referenced
this pull request
Jan 12, 2022
…TriggerAdapter::triggers_in_blocks` (#3082) With the revamped `FirehoseBlockStream`, it's now possible to directly re-use the `TriggerAdapter::triggers_in_blocks` code instead of relying on our specialized `firehose_triggers_in_block`. This make the code more re-usable. Eliminated at the same time a useless close in `NearChair::TriggersAdapter`. Also make some `NearChain` now panics instead of silently returning something that is not good. Linked to #3080 Co-authored-by: Matthieu Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the revamped
FirehoseBlockStream, it's now possible to directly re-use theTriggerAdapter::triggers_in_blockscode instead of relying on our specializedfirehose_triggers_in_block. This make the code more re-usable.Eliminated at the same time a useless close in
NearChair::TriggersAdapter. Also make someNearChainnow panics instead of silently returning something that is not good.Linked to #3080
Note
Based on #3078