graph,graphql,store: nested sorting #3096

kamilkisiela · 2021-12-23T15:55:00Z

Given this schema:

type Country @entity {
  id: ID!
  capital: City!
  cities: [City!]!
}

type City @entity {
  id: ID!
  name: String
  population: Int
  landmarks: [String!]!
}

It adds fields of child entity to *_orderBy enum:

enum Country_orderBy {
   id
   capital
   cities
+  capital__id
+  capital__name
+  capital__population
}

sort by type Child @entity { name: String }
sort by type Child @entity { id: ID }
can't sort by type Child @entity { names: [String] }
can't sort by type Child @entity { secondLevelChild: AnotherEntity }
can't sort by type Child @entity { secondLevelChildren: [AnotherEntity] }
support @derivedFrom
sort by interface Child { name: String }
sort by interface Child { id: ID }
sort interface by type Child @entity { name: String } (done in Nested Sorting: interface by non-derived child entity #4058)

graphql/src/store/query.rs

store/postgres/src/relational_queries.rs

graphql/src/schema/api.rs

lutter

I started reviewing this, but then realized that it also deals with sorting by interface fields, and now I am not certain how it relates to PR #4058. Should I continue reviewing this or is this superseded by that PR?

graphql/src/schema/api.rs

graphql/src/store/query.rs

graph/src/components/store/mod.rs

kamilkisiela · 2022-11-04T10:01:26Z

@lutter

I started reviewing this, but then realized that it also deals with sorting by interface fields, and now I am not certain how it relates to PR #4058. Should I continue reviewing this or is this superseded by that PR?

It deals with sorting by interface fields, #4058 adds sorting an interface by children (as it's a bit more complex).

lutter

I am still not completely through the PR, but figured these comments would be good to address to make some progress.

store/postgres/src/relational_queries.rs

graph/src/components/store/mod.rs

store/postgres/src/relational_queries.rs

kamilkisiela · 2022-11-24T15:37:30Z

@lutter about the failing test, it works locally but I will try to use exact version on PostgreSQL docker image.

kamilkisiela · 2022-11-24T15:53:10Z

@lutter

Rows of musicians table are sorted by main_band, block_range columns. You can see that b1 is used by two musicians.

Sometimes the unit test is 🟢, but sometimes it's 🔴 .

Do you think that the order of row insertion affects the end result? These two rows are pretty much identical (block_range and main_band).

entity	data
Musician	{"id": "m2", "vid": 1, "name": "Lisa", "bands": ["b1"], "main_band": "b1", "block_range": "[0,)"}
Musician	{"id": "m1", "vid": 2, "name": "John", "bands": ["b1", "b2"], "main_band": "b1", "block_range": "[0,)"}
Musician	{"id": "m3", "vid": 3, "name": "Tom", "bands": ["b1", "b2"], "main_band": "b2", "block_range": "[1,)"}
Musician	{"id": "m4", "vid": 4, "name": "Valerie", "bands": [], "main_band": null, "block_range": "[1,)"}

After running the unit tests, I run the query generated by graph-node:

select 'Musician' as entity, to_jsonb(c.*) as data from (select  c.*
 from "sgd21"."musician" c left join "sgd21"."band" as cc on (cc."id" = c."main_band" and cc."block_range" @> 1)
where c.block_range @> 1
order by cc."id", cc.block_range
limit 100) c

I always get consistent results.

lutter · 2022-12-01T00:24:42Z

select 'Musician' as entity, to_jsonb(c.*) as data from (select  c.*
 from "sgd21"."musician" c left join "sgd21"."band" as cc on (cc."id" = c."main_band" and cc."block_range" @> 1)
where c.block_range @> 1
order by cc."id", cc.block_range
limit 100) c

I am not entirely sure what is going on here; for me locally, can_query_with_sorting_by_child_entity_id fails consistently. Is that the test you are talking about? If so, it should say order by cc.name, cc.id, cc.block_range based on the GraphQL for asc.

lutter

Nice work! Sorry it took so long to review.

One final thing: we should have an environment variable GRAPH_GRAPHQL_DISABLE_CHILD_SORTING which defaults to false that we can set to turn this off if it leads to performance issues. The flag should work just the same as GRAPH_GRAPHQL_DISABLE_BOOL_FILTERS does. I left comments where I think this needs to be checked to (a) suppress child sorting in the GraphQL schema and (b) return an error in queries.

Other than that, this should be good to go.

graphql/src/store/query.rs

graphql/src/schema/api.rs

graphql: test orderBy enum graphql: do not sort an interface by child-level entity graphql: merge Object and Interface match case graphql: Do not pass field type store: avoid expect Avoid format macro Make ChildKeyDetails more expressive Use constraint_violation macro Sorting by child id Require less data Refactor EntityOrderByChild* Support sorting by child id Add GRAPH_GRAPHQL_DISABLE_CHILD_SORTING (false by default)

dotansimha · 2023-02-14T01:32:35Z

@lutter merged with the integration tests failing, it seems like the same on master. Unrelated to this PR, and the only change was a rebase.

kamilkisiela commented Dec 23, 2021

View reviewed changes

graphql/src/store/query.rs Outdated Show resolved Hide resolved

kamilkisiela commented Dec 23, 2021

View reviewed changes

graphql/src/store/query.rs Outdated Show resolved Hide resolved

kamilkisiela commented Dec 28, 2021

View reviewed changes

store/postgres/src/relational_queries.rs Outdated Show resolved Hide resolved

kamilkisiela commented Dec 29, 2021

View reviewed changes

graphql/src/schema/api.rs Show resolved Hide resolved

kamilkisiela force-pushed the kamil-filter-by-child branch from e3e551a to ad81c2b Compare January 13, 2022 13:28

kamilkisiela force-pushed the kamil-sorting branch 2 times, most recently from 980d3a8 to 2c84c57 Compare January 13, 2022 13:35

kamilkisiela marked this pull request as ready for review January 14, 2022 12:14

kamilkisiela force-pushed the kamil-filter-by-child branch from ad81c2b to c288e18 Compare January 20, 2022 13:36

kamilkisiela force-pushed the kamil-sorting branch from 2c84c57 to 578da46 Compare January 20, 2022 13:40

kamilkisiela force-pushed the kamil-filter-by-child branch from c288e18 to c02173a Compare January 24, 2022 11:31

kamilkisiela force-pushed the kamil-sorting branch from 578da46 to 5757058 Compare January 24, 2022 11:32

kamilkisiela force-pushed the kamil-filter-by-child branch from c02173a to 9afb13b Compare January 25, 2022 09:00

kamilkisiela force-pushed the kamil-sorting branch from 5757058 to adc77ed Compare January 25, 2022 09:18

kamilkisiela force-pushed the kamil-filter-by-child branch from 9afb13b to 46d2872 Compare March 3, 2022 17:02

kamilkisiela force-pushed the kamil-sorting branch from adc77ed to 6565873 Compare March 3, 2022 17:28

dotansimha force-pushed the kamil-filter-by-child branch from 46d2872 to 771a995 Compare March 8, 2022 15:30

dotansimha mentioned this pull request Mar 8, 2022

Allow to filter queries by child entity #3184

Merged

dotansimha force-pushed the kamil-sorting branch from 6565873 to 1b71839 Compare March 8, 2022 15:36

dotansimha force-pushed the kamil-filter-by-child branch 2 times, most recently from 809b6fd to f34918a Compare March 13, 2022 14:48

kamilkisiela force-pushed the kamil-filter-by-child branch from f34918a to 2a77b5d Compare April 5, 2022 10:51

kamilkisiela force-pushed the kamil-filter-by-child branch 2 times, most recently from 1e9f27b to 5523cf7 Compare April 27, 2022 12:35

dotansimha force-pushed the kamil-filter-by-child branch 2 times, most recently from 6e04d05 to 6f9312f Compare May 3, 2022 06:28

kamilkisiela force-pushed the kamil-filter-by-child branch 3 times, most recently from b863adb to 461a827 Compare May 4, 2022 09:38

kamilkisiela force-pushed the kamil-filter-by-child branch from 461a827 to 2c30a78 Compare May 23, 2022 12:37

kamilkisiela changed the title ~~WIP: Sorting by child fields~~ WIP: Nested Sorting Aug 31, 2022

tilacog mentioned this pull request Sep 21, 2022

Integrate Epoch Block Oracle graphprotocol/indexer#479

Merged

kamilkisiela force-pushed the kamil-sorting branch 2 times, most recently from 5e8be64 to cce0b3b Compare September 26, 2022 10:55

kamilkisiela changed the title ~~WIP: Nested Sorting~~ Nested Sorting Sep 26, 2022

kamilkisiela force-pushed the kamil-sorting branch 2 times, most recently from 230c169 to 1d9d19d Compare October 5, 2022 13:12

lutter reviewed Oct 17, 2022

View reviewed changes

kamilkisiela force-pushed the kamil-sorting branch from 1d9d19d to 4f1adae Compare November 4, 2022 09:06

lutter requested changes Nov 8, 2022

View reviewed changes

kamilkisiela force-pushed the kamil-sorting branch 2 times, most recently from 4b0a0f5 to 1d343e1 Compare January 12, 2023 12:24

kamilkisiela requested a review from lutter January 12, 2023 13:01

lutter approved these changes Feb 3, 2023

View reviewed changes

graphql/src/store/query.rs Outdated Show resolved Hide resolved

graphql/src/schema/api.rs Show resolved Hide resolved

kamilkisiela force-pushed the kamil-sorting branch from 1d343e1 to 7910ff1 Compare February 10, 2023 16:09

neysofu mentioned this pull request Feb 13, 2023

v0.30.0 release notes #4363

Merged

2 tasks

lutter approved these changes Feb 13, 2023

View reviewed changes

dotansimha force-pushed the kamil-sorting branch from 7910ff1 to 78adcbb Compare February 14, 2023 01:04

dotansimha changed the title ~~Nested Sorting~~ graph,graphql,store: nested sorting Feb 14, 2023

dotansimha merged commit b4d589a into master Feb 14, 2023

dotansimha deleted the kamil-sorting branch February 14, 2023 01:32

neysofu pushed a commit that referenced this pull request Feb 16, 2023

graph,graphql,store: nested sorting (#3096)

50ce895

neysofu pushed a commit that referenced this pull request Feb 16, 2023

graph,graphql,store: nested sorting (#3096)

5dde144

saihaj mentioned this pull request Mar 9, 2023

docs: nested sorting graphprotocol/docs#307

Merged

graph,graphql,store: nested sorting #3096

graph,graphql,store: nested sorting #3096

Uh oh!

Conversation

kamilkisiela commented Dec 23, 2021 • edited by dotansimha Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lutter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kamilkisiela commented Nov 4, 2022

Uh oh!

lutter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kamilkisiela commented Nov 24, 2022

Uh oh!

kamilkisiela commented Nov 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lutter commented Dec 1, 2022

Uh oh!

lutter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dotansimha commented Feb 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kamilkisiela commented Dec 23, 2021 •

edited by dotansimha

Loading

kamilkisiela commented Nov 24, 2022 •

edited

Loading