Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pienkowb
Copy link
Contributor

@pienkowb pienkowb commented Feb 1, 2022

No description provided.

* TendermintTrigger variant fields are generated by prost and don't implement PartialOrd
* need to rely on the Ord impl
@evaporei
Copy link
Contributor

@patiee @pienkowb I remember that you folks mentioned that you might be able to use the direct .proto files from the official tendermint repo, did that workout or we're going with the current approach?

If we're keeping this one, I've answered all comments and resolved the ones that nothing should be done about πŸ™‚

@pienkowb
Copy link
Contributor Author

@patiee @pienkowb I remember that you folks mentioned that you might be able to use the direct .proto files from the official tendermint repo, did that workout or we're going with the current approach?

We're still experimenting with importing the official .proto files, we should reach a conclusion this week. I'll let you know!

Copy link
Contributor

@evaporei evaporei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Congrats πŸ‘

@evaporei
Copy link
Contributor

evaporei commented Mar 8, 2022

@pienkowb the unit tests are failing, can you double check why that is?

@pienkowb
Copy link
Contributor Author

pienkowb commented Mar 8, 2022

@otaviopace I'm checking it. BTW, we might want to clean up the commit history before merging.

@evaporei
Copy link
Contributor

evaporei commented Mar 8, 2022

We can just squash them πŸ™‚

@evaporei
Copy link
Contributor

@pienkowb the tests are failing because of arguments that changed in some parts of the codebase

@pienkowb
Copy link
Contributor Author

@otaviopace The tests are passing now :)

+1 for squashing the commits into one.

@evaporei evaporei dismissed tilacog’s stale review March 14, 2022 13:37

no longer valid

@evaporei evaporei merged commit a7c6ced into graphprotocol:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants