v0.29.0 release notes #4199
Closed
v0.29.0 release notes #4199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azf20
suggested changes
Nov 23, 2022
Contributor
azf20
left a comment
There was a problem hiding this comment.
Thanks! Left some small comments
Contributor
Author
|
This branch is NOT to be merged into |
f606849 to
c0ba500
Compare
This is being done by changing `revert_subgraph_errors` to change both the `failed` and `status` columns in the case of both being `failed`. Without this change, rewinding failed subgraphs past the failed block would result in the `failed` status staying the same.
c0ba500 to
12c0425
Compare
12c0425 to
6499d38
Compare
Contributor
Author
|
Closing in favor of #4298. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥳
@azf20 my proposed release notes are here. Blockers:
failedstatus on graphman rewind #4174