Thanks to visit codestin.com
Credit goes to github.com

Skip to content

don't fail ingestor on net_version changed from zero #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

don't fail ingestor on net_version changed from zero #4692

merged 1 commit into from
Jun 14, 2023

Conversation

@sduchesneau
Copy link
Contributor

@sduchesneau sduchesneau commented Jun 13, 2023

If a chain was first set up using firehose and we then try to switch to an RPC provider, we get an error on a failing safety check for net_version.

Before this fix:

Jun 13 09:37:26.175 ERRO the net version for chain mainnet has changed from 0 to 1 since the last time we ran, component: BlockStore
Jun 13 09:37:26.186 INFO Creating LoadManager in disabled mode, component: LoadManager
Jun 13 09:37:26.187 ERRO Failed to create block ingestor Not starting block ingestor (chain is defective), network_name mainnet, network_name: mainnet

After this fix:
Jun 13 11:11:03.201 WARN the net version for chain mainnet has changed from 0 to 1 since the last time we ran, ignoring difference because 0 means UNSET and firehose does not provide it, component: BlockStore

@sduchesneau sduchesneau requested a review from leoyvens June 13, 2023 15:13
@sduchesneau
Copy link
Contributor Author

sduchesneau commented Jun 13, 2023

this is also a blocker for firehose-to-rpc switching, stated here: #4670

@leoyvens leoyvens merged commit c8b04a7 into master Jun 14, 2023
@leoyvens leoyvens deleted the stepd/fh_to_rpc_ignore_netversion branch June 14, 2023 09:55
@yohanelly95
Copy link

yohanelly95 commented May 12, 2024

getting this error at the moment, but its showing hex to number chain id changes. How do we resolve this? this apparently effects grafting as well, we graft to a new sgd it copies all previous data but stops indexing from the block it initially stopped working with this error Not starting block ingestor (chain is defective). hey @leoyvens any insights here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoyvens leoyvens leoyvens approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sduchesneau @yohanelly95 @leoyvens