Avoid redundant child queries #4827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
approved these changes
Aug 30, 2023
Collaborator
Author
|
@mangas Thanks for approving - I added one more commit to have a feature flag to turn all this off. Not sure if you want to have another look. |
We used to omit entries for parents that have no children from the `ParentLink` which would violate the constraint that the child/children for the ith parent is in the ith place in the list of child ids. That is not a problem for the SQL queries we generate, but can be an issue for other uses of the data structure.
If a query only needs to get the id of children, and we already have them in memory, do not run a query to fetch them again. Instead, construct the appropriate objects in memory. Fixes #4261
Setting GRAPH_STORE_DISABLE_CHILD_OPTIMIZATION=1 will disable the child optimization. This is meant as a safety switch in case the optimization causes problems.
fa0373a to
9c65a8d
Compare
lutter
added a commit
that referenced
this pull request
Sep 6, 2023
This is a follow-on to #4827 to cover the important case where no ordering is specified (for example, for single-value child fields)
lutter
added a commit
that referenced
this pull request
Sep 8, 2023
This is a follow-on to #4827 to cover the important case where no ordering is specified (for example, for single-value child fields)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a query only needs to get the
idof children, and we already have them in memory, do not run a query to fetch them again. Instead, construct the appropriate objects in memory.Fixes #4261