graph, graphql: Expand which fields we optimize away #4853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
approved these changes
Sep 7, 2023
This reverts commit 906f5e6. That commit caused a bug because of a confusion about which list of parent ids to use. If we had entities without children followed by ones with children, we would join the wrong children to parents. We now use the correct list of parent ids, the one that already has entries with no children filtered out.
We add a new band member to The Amateurs for our query test. We need a situation where an entity that has empty relations to other entities is followed by one that does have them to ensure that we link up the children correctly in that situation.
This is a follow-on to #4827 to cover the important case where no ordering is specified (for example, for single-value child fields)
bfca747 to
3cdf705
Compare
When we resolve a child query from memory, the `first` applies to the list of children for each parent, not the number of total parents.
Collaborator
Author
|
Closing this for the reasons explained in #4261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #4827 to cover the important case where no ordering is specified (for example, for single-value child fields)