store: Fix handling of enum arrays #5764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roundtripping arrays of enums would fail because we would read an array of
enums back as a single string "{yellow,red,BLUE}" instead of the array
["yellow", "red", "BLUE"]. Storing an update to such an entity, even if
users make no changes to that field, would fail because Postgres expects an
array and we were sending a scalar value.
This fixes a bug introduced in PR
#5372
encalypto
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roundtripping arrays of enums would fail because we would read an array of enums back as a single string "{yellow,red,BLUE}" instead of the array ["yellow", "red", "BLUE"]. Storing an update to such an entity, even if users make no changes to that field, would fail because Postgres expects an array and we were sending a scalar value.
This fixes a bug introduced in PR
#5372