Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ExecutionStepInfo now has a direct transform without a Builder #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

ExecutionStepInfo now has a direct transform without a Builder #3934

merged 2 commits into from
May 14, 2025

Conversation

bbakerman
Copy link
Member

This is really 1% stuff. Its debatably faster BUT it uses (slightly) less memory and thats a good thing at scale

Benchmark                                                        (howManyItems)   Mode  Cnt    Score    Error  Units
ExecutionStepInfoBenchmark.benchMarkBuilderThroughput                   1000000  thrpt    4  376.814 ±  7.136  ops/s
ExecutionStepInfoBenchmark.benchMarkBuilderThroughput                   2000000  thrpt    4  188.889 ±  2.585  ops/s
ExecutionStepInfoBenchmark.benchMarkDirectConstructorThroughput         1000000  thrpt    4  379.725 ± 13.369  ops/s
ExecutionStepInfoBenchmark.benchMarkDirectConstructorThroughput         2000000  thrpt    4  191.496 ±  1.785  ops/s

@bbakerman bbakerman added the performance work that is primarily targeted as performance improvements label Apr 28, 2025
@bbakerman bbakerman requested a review from andimarek April 28, 2025 02:16
@github-actions GitHub Actions
Copy link
Contributor

Test Results

  312 files    312 suites   54s ⏱️
3 581 tests 3 576 ✅ 5 💤 0 ❌
3 670 runs  3 665 ✅ 5 💤 0 ❌

Results for commit 237d6bb.

@bbakerman bbakerman requested a review from dondonz April 28, 2025 04:41
@bbakerman bbakerman mentioned this pull request Apr 29, 2025
Open
@dondonz dondonz merged commit 1a760d7 into master May 14, 2025
2 checks passed
@dondonz dondonz mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondonz dondonz dondonz approved these changes

@andimarek andimarek Awaiting requested review from andimarek

Assignees
No one assigned
Labels
performance work that is primarily targeted as performance improvements
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bbakerman @dondonz