Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: properly use type hints #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: properly use type hints #10

merged 1 commit into from
Jan 30, 2023

Conversation

mahdyhamad
Copy link
Contributor

Description:

Python throws the TypeError: object is not subscriptable if you use indexing with the square bracket notation on an object that is not indexable.

To solve this issue, indexed types is used

@mahdyhamad mahdyhamad mentioned this pull request Jan 30, 2023
Closed
@coveralls
Copy link

coveralls commented Jan 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4042446135

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 91.111%
Totals Coverage Status
Change from base Build 3782172909: 0.04%
Covered Lines: 205
Relevant Lines: 225
💛 - Coveralls

@erikwrede
Copy link
Member

Good catch! We should keep the 3.6-style type hints for list and dict until 3.10 is the oldest supported python version.

@erikwrede
Copy link
Member

Can you fix the other affected files in the PR as well? It makes little sense to push a release that only supports half of that. If you have time, I can release it right after that 🙂

mahdyhamad
mahdyhamad commented Jan 30, 2023
View reviewed changes
@mahdyhamad mahdyhamad force-pushed the fix_type_hints branch 2 times, most recently from a9e9b16 to e4732c2 Compare January 30, 2023 10:26
@mahdyhamad mahdyhamad requested a review from erikwrede January 30, 2023 18:07
@mahdyhamad mahdyhamad changed the title fix(providers.py, service.py): properly use type hints fix: properly use type hints Jan 30, 2023
@erikwrede erikwrede merged commit 4fe6404 into graphql-python:main Jan 30, 2023
@erikwrede
Copy link
Member

Thank you! 🙂

@mahdyhamad mahdyhamad deleted the fix_type_hints branch January 30, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwrede erikwrede erikwrede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahdyhamad @coveralls @erikwrede