fix: Federation V2 Scalar Support #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort-federation-v2 # Conflicts: # README.md # examples/inaccessible.py # examples/override.py # examples/shareable.py # examples/tag.py # graphene_federation/entity.py # graphene_federation/extend.py # graphene_federation/external.py # graphene_federation/inaccessible.py # graphene_federation/override.py # graphene_federation/provides.py # graphene_federation/requires.py # graphene_federation/service.py # graphene_federation/shareable.py # graphene_federation/tag.py # graphene_federation/tests/test_key.py
# Conflicts: # graphene_federation/extend.py # graphene_federation/service.py
Fix: Lint Error Passed: Test Cases
# Conflicts: # graphene_federation/entity.py # graphene_federation/extend.py # graphene_federation/utils.py
Pull Request Test Coverage Report for Build 4519903383Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
patrick91
reviewed
Mar 25, 2023
patrick91
reviewed
Mar 25, 2023
77db6ed to
7500690
Compare
7500690 to
4b41062
Compare
patrick91
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
Looks good, I wonder if we should rebase since there's 102 commits in the PR. But I guess we'll just squash this when merging 😊
Also /cc @erikwrede for a final check
patrick91
reviewed
Mar 25, 2023
Yes, It's happened somehow! Please squash this when merging! |
erikwrede
approved these changes
Mar 26, 2023
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : Breaks with custom scalars #13