Add: New openvasd scanner type and relay fields #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
+ Coverage 97.74% 97.79% +0.04%
==========================================
Files 71 73 +2
Lines 4967 5114 +147
Branches 895 928 +33
==========================================
+ Hits 4855 5001 +146
Misses 76 76
- Partials 36 37 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjoernricks
reviewed
Mar 24, 2025
Contributor
bjoernricks
left a comment
There was a problem hiding this comment.
I think we should increment the protocol version to 22.7. If we take it seriously this is a new feature and therefore requires a new minor version.
The latest GMP protocol version now supports the openvasd scanner type and the new scanner fields relay_host and relay_port.
ea365e0 to
af12b2a
Compare
auto-merge was automatically disabled
April 14, 2025 10:33
Pull request was converted to draft
…sd' into add-scanner-relays-and-openvasd
bjoernricks
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The latest GMP protocol version now supports the openvasd scanner type and the new scanner fields relay_host and relay_port.
Why
To be able to use the new scanner type and define relays for scanners.
References
GEA-987
The new optional relay fields require greenbone/gvmd/pull/2399
Checklist