Fix PHP 8 deprecation notice #331
Conversation
When using the project with PHP 8, you get the following notice: ``` PHP Deprecated: Required parameter $options follows optional parameter $qchars in vendor\greenlion\php-sql-parser\src\PHPSQLParser\utils\ExpressionToken.php on line 59 ```
|
Just ran into this issue myself. Any idea of when this will be merged and released? I actually fixed it locally by defaulting Options to null as well, and then allowing a null default on the private member function revokeQuotation. Looks like revokeQuotation is only called once, but will accept a null. Not sure the best approach in the code. |
|
What is the status of this PR? PHP 8.0 has been out for a while and this PR looks like it solves the problem. Should probably be merged and tagged. I looked into the PHPMyAdmin SQL parser, and this is the better parser, so it is worth maintaining. |
|
@greenlion Plis man 🌵 |
|
Will merge it early next week. I am busy until then.
Thank you for the contribution.
…On Thu, Mar 18, 2021, 9:18 AM Harm Smits ***@***.***> wrote:
@greenlion <https://github.com/greenlion> Plis man 🌵
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADRTNSWFGUPMJSYPZRKXUDTEH4UBANCNFSM4VH7I5DQ>
.
|
|
@greenlion I assume you did not have any time? Could you kindly let me know when it can be merged? Otherwise I can do it myself as well if you give me according rights. |
|
I did forget. I will do it this evening.
…On Sun, Mar 28, 2021, 2:38 PM Harm Smits ***@***.***> wrote:
@greenlion <https://github.com/greenlion> I assume you did not have any
time? Could you kindly let me know when it can be merged? Otherwise I can
do it myself as well if you give me according rights.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADRTNTDVXLMQYD3KAYSIL3TF6AS5ANCNFSM4VH7I5DQ>
.
|
|
Tested locally. Will rollback if online regression tests fail. |
When using the project with PHP 8, you get the following notice: