Fix confusion between CHARACTER data type and CHARACTER SET issue #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an attempt to fix the character set issue introduced by me in greenlion#355 This change separates out the CHARACTER check to do a look ahead to see if the next keyword is SET and splits the logic appropriately. An alternative would be to look back at the constructed expression array ($expr) to see if a ExpressionType::DATA_TYPE has already been defined. This is an alternative fix to the fix proposed by greenlion#366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusion between
CHARACTERtype andCHARACTER SETIn an attempt to fix the data type aliases per #355, I introduced a bug documented in #365.
This change separates out the
CHARACTERcheck to do a look ahead to see if the next keyword is `SET and splits the logic appropriately.An alternative would be to look back at the constructed expression array (
$expr) to see if aExpressionType::DATA_TYPEhas already been defined.Additionally this also includes a fix to support
CHARSETwhich is a valid alias forCHARACTER SETper the MySQL character sets documentation.This is an alternative to the fix proposed by #366