Custom Responsive Sort Order #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `oneColumnModeDomSort` true|false to let you specify a custom layout (use dom order instead of x,y) for oneColumnMode `setColumn(1)` * fix for #713 * better than PR #966 which attempted to make a generic support for oneColumn only mode, yet didn't modify the other layouts sorting. Instead user will have complete control (dom order) iresptive of layouts sort. Also works with current setColumn() implementation * added karma tests * Note: you cannot change this flag and expect 1 column (which is cached) to change (can see in column.html, unless you add/remove items in larger layouts the blows caches). Future todo.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
oneColumnModeDomSorttrue|false to let you specify a custom layout (use dom order instead of x,y) for oneColumnModesetColumn(1)fix for Custom Responsive Sort Order #713
better than PR Adding Support for oneColumnModeSort Options (Custom Responsive Sort Order) #966 which attempted to make a generic support for oneColumn only mode, yet didn't modify the other layouts sorting.
Instead user will have complete control (dom order) iresptive of layouts sort.
Also works with current setColumn() implementation
added karma tests
Note: you cannot change this flag and expect 1 column (which is cached) to change (can see in column.html,
unless you add/remove items in larger layouts the blows caches). Future todo.
Checklist
yarn test)