adding styleInHead option #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Jul 30, 2020
src/gridstack.js
Outdated
| @@ -1092,8 +1093,9 @@ | |||
| Utils.removeStylesheet(this._stylesId); | |||
| } | |||
| this._stylesId = 'gridstack-style-' + (Math.random() * 100000).toFixed(); | |||
| // insert style to parent (instead of 'head') to support WebComponent | |||
| this._styles = Utils.createStylesheet(this._stylesId, this.el.parentNode); | |||
| var styleLocation = this.opts.styleInHead ? false : this.el.parentNode | |||
There was a problem hiding this comment.
I would use null or undefined instead since parent is an element pointer (issue in typescript version) but works here in JS.
There was a problem hiding this comment.
changed to undefined
|
thank you for contributing - great job at documenting and testing this. I can make a new release soon if nothing else comes up.. |
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Jul 30, 2020
adumesny
added a commit
that referenced
this pull request
Jul 30, 2020
typedef for #1313 styleInHead option
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Jul 31, 2020
adumesny
added a commit
that referenced
this pull request
Jul 31, 2020
TS: adding styleInHead option for #1313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows for keeping older behavior of gridstack where
<STYLE>was added to<HEAD>instead of parentNode. The default behavior remains to be to use parentNode but in situations whereheadis preferrable just passstyleInHead = trueto gridstack options.Checklist
gridstack.js/developthough