Vue3 example #1404
Merged
Vue3 example #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
requested changes
Oct 6, 2020
There was a problem hiding this comment.
Angelo, thank you for doing this, but can you make it EXACTLY the same as the 2.0 version that is checked in (down to the style and includes of demo styles) other than import { createApp } and .mount("#app") part so it's easier to diff the two and see what changed for 3.0 ?
Also, please append your file to index.html and readme link, maybe rename the existing one vue2ls.html
and finally, merge all your git changes into just 1 if possible (git rebase -i HEAD~3 and squash, the git push -f to update your commits), otherwise I can do it when I accept I suppose.
| node_modules | ||
| .vscode |
There was a problem hiding this comment.
why you want .vscode inside the repo?
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Oct 11, 2020
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Oct 11, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've created an example of gridstack used in a vue3 js.