Bugfix/amd jquery ui #151
Merged
Bugfix/amd jquery ui #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gridstack was previously loading in jquery and lodash, but not the necessary jquery-ui components. As gridstack's bower.json now includes jQueryUI, there should be no issue in requiring it into gridstack. I've verified that this works in my AMD build. For reference, I'm defining jquery-ui as such in my require.config paths section:
'jquery-ui': 'vendor/jquery-ui/ui/',The decision to call it 'jquery-ui' vs 'jqueryui' or simple 'ui' was made because the (very poor) jquery-ui documentation references their components by
jquery-ui/*as found here:http://learn.jquery.com/jquery-ui/environments/amd/