big sidepanel drag&drop helper rewrite #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix gridstack#2231 gridstack#1840 gridstack#2354 * big overall to how we do sidepanel drag&drop helper * `clone()` helper is now passed full HTML element dragged, not an event * use any class/structure you want for side panel items * `GridStack.setupDragIn()` now support associating a `GridStackWidget` for each sidepanel that will be used to define what to create on drop! * if no `GridStackWidget` is defined, the helper will now be inserted as is, and NOT original sidepanel item. Updated two.html to showcase all use cases and more. TODO: simplify other demos...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clone()helper is now passed full HTML element dragged, not an eventGridStack.setupDragIn()now support associating aGridStackWidgetfor each sidepanel that will be used to define what to create on drop!GridStackWidgetis defined, the helper will now be inserted as is, and NOT original sidepanel item.Updated two.html to showcase all use cases and more. TODO: simplify other demos...
Checklist
yarn test)