Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix positioning bug with NE,NW resize handles #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix positioning bug with NE,NW resize handles #2874

merged 1 commit into from
Nov 18, 2024

Conversation

rsalcedo6
Copy link
Contributor

Description

The NE & NW resize handles aren't positioned correctly when using custom margin grid option.
Here is an example jsfiddle.
This PR fixes the issue on my local testing

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
    • I am unable to successfully run the tests on my macbook. It's having a karma error. I didn't have enough time to figure this out
  • Extended the README / documentation, if necessary

@adumesny adumesny merged commit 5e59a88 into gridstack:master Nov 18, 2024
@adumesny
Copy link
Member

thanks for the fix!

@adumesny adumesny mentioned this pull request Nov 18, 2024
Closed
3 tasks
@rsalcedo6
Copy link
Contributor Author

thanks for the fix!

My pleasure.

@rsalcedo6 rsalcedo6 deleted the fix-resize-handles branch November 21, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsalcedo6 @adumesny