Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove ES5 support #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ module.exports = function(grunt) {
copy: {
dist: {
files: {
'dist/es5/gridstack-poly.js': ['src/gridstack-poly.js'],
'dist/src/gridstack.scss': ['src/gridstack.scss'],
'dist/angular/README.md': ['angular/README.md'],
'dist/angular/src/gridstack.component.ts': ['angular/projects/lib/src/lib/gridstack.component.ts'],
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Alternatively (single combined file, notice the -all.js) in html
<script src="node_modules/gridstack/dist/gridstack-all.js"></script>
```

**Note**: IE support was dropped in v2, but restored in v4.4 by an external contributor (I have no interest in testing+supporting obsolete browser so this likely will break again in the future).
**Note**: IE support was dropped in v2, but restored in v4.4 by an external contributor (I have no interest in testing+supporting obsolete browser so this likely will break again in the future) and DROPPED again in v12 (css variable needed).
You can use the es5 files and polyfill (larger) for older browser instead. For example:
```html
<link href="node_modules/gridstack/dist/gridstack.min.css" rel="stylesheet"/>
Expand Down
4 changes: 1 addition & 3 deletions demo/web1.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
<script type="module" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.esm.js"></script>
<script nomodule="" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.js"></script>

<!-- support for IE -->
<script src="../dist/es5/gridstack-poly.js"></script>
<script src="../dist/es5/gridstack-all.js"></script>
<script src="../dist/gridstack-all.js"></script>
</head>

<body>
Expand Down
4 changes: 1 addition & 3 deletions demo/web2.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
<script type="module" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.esm.js"></script>
<script nomodule="" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.js"></script>

<!-- support for IE -->
<script src="../dist/es5/gridstack-poly.js"></script>
<script src="../dist/es5/gridstack-all.js"></script>
<script src="../dist/gridstack-all.js"></script>

<style type="text/css">
.grid-stack-item-removing {
Expand Down
5 changes: 5 additions & 0 deletions doc/CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Change log
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
**Table of Contents** *generated with [DocToc](http://doctoc.herokuapp.com/)*

- [12.0.0-dev (TBD)](#1200-dev-tbd)
- [12.0.0 (2025-04-12)](#1200-2025-04-12)
- [11.5.1 (2025-03-23)](#1151-2025-03-23)
- [11.5.0 (2025-03-16)](#1150-2025-03-16)
Expand Down Expand Up @@ -123,6 +124,10 @@ Change log
- [v0.1.0 (2014-11-18)](#v010-2014-11-18)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

## 12.0.0-dev (TBD)
* removed ES5 support (IE doesn't support CSS vars needed now)

## 12.0.0 (2025-04-12)
* feat: [#2854](https://github.com/gridstack/gridstack.js/pull/2854) Removed dynamic stylesheet and migrated to CSS vars. Thank you [lmartorella](https://github.com/lmartorella)
* feat: [#3013](https://github.com/gridstack/gridstack.js/pull/3013) columns no longer require custom classes nor `gridstack-extra.css` as we now use CSS vars.
Expand Down
29 changes: 0 additions & 29 deletions es5/tsconfig.json

This file was deleted.

22 changes: 0 additions & 22 deletions es5/webpack.config.js

This file was deleted.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@
}
],
"scripts": {
"build": "yarn --no-progress && yarn build:ng && grunt && yarn build:es6 && yarn build:es5 && yarn doc",
"build": "yarn --no-progress && yarn build:ng && grunt && yarn build:es6 && yarn doc",
"build:es6": "webpack && tsc --stripInternal",
"build:es5": "webpack --config es5/webpack.config.js && tsc --stripInternal --project es5/tsconfig.json",
"build:ng": "cd angular && yarn --no-progress && yarn build lib",
"w": "webpack",
"t": "rm -rf dist/* && grunt && tsc --stripInternal",
Expand Down
Loading