Allow negative numbers to be passed to parseHeight function #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the failed checks. I will update the pull request tonight. |
|
What's the scenario when you'd want a negative vertical margin? |
|
Let's say you have set borders for each "grid-stack-item-content" to 10px and want to display each grid item seamlessly without displaying border twice then you need to decrease the space between the items for one border width. A verticalMargin('0') is not enough to display the items seamlessly. verticalMargin('0'):
verticalMargin('-10px'):
|
|
Please update unit tests for |
troolee
added a commit
that referenced
this pull request
Mar 1, 2016
Allow negative numbers to be passed to parseHeight function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to call for example the verticalMargin method with negative numbers.
Instead of bypassing the method