Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#757 Fixed returning of an array of actually changed widgets #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

#757 Fixed returning of an array of actually changed widgets #789

wants to merge 1 commit into from

Conversation

vadus1
Copy link

@vadus1 vadus1 commented Sep 19, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.59% when pulling be25e42 on vadus1:develop into 57c6511 on gridstack:develop.

@radiolips
Copy link
Member

@vadus1 What's this fix?

@adumesny
Copy link
Member

adumesny commented Dec 17, 2019 •
edited
Loading

this is NOT the right fix, because if you temporally move other objects out while dragging one, they will not return to original position (_dirty from _origY will be FALSE, so new GridStackEngine() onChange() callback will not be called to do a self._updateStyles(maxHeight + 10); on line 784

what we actually need is store the original X/Y/W/H and compare in _triggerChangeEvent() rather than just check for _dirty flag

@adumesny adumesny closed this Dec 17, 2019
@adumesny adumesny mentioned this pull request Dec 17, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadus1 @coveralls @radiolips @adumesny