Export on the correct scope for each environment. #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RequireJS and CommonJS now export on the `exports` module. `window` exports in these environments are now removed no longer available. Other environments still export on the `window`.
|
Coveralls is reporting decreased coverage because I added a new argument to the module factory, which is not covered by tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequireJS and CommonJS now export on the
exportsmodule.windowexports in these environments are now removed no longer available.
Other environments still export on the
window.This fixes #643.
I think you should pay special attention to the fact that exporting to the
windowobject is now gone on RequireJS and CommonJS exports, as they now correctly export just in their preferredexportsmodule. This is probably a major breaking change, might be good to update the readme or whatever.Do you need me to update a changelog too, before merging? I also ran
npm buildso the files in thedistdirectory are also updated.Checklist
npm test)