Update bower.json main files to match "standards" #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update allows use of bower.json main value in buildtools that rely on the appropriate files being defined in this main array. It also points to the unminified, but compiled dist versions as per bower spec: https://github.com/bower/bower.json-spec#main * Changes main js file to use unminified version * Adds the gridstack.css file to the main files array * Moves compiled CSS into `dist` folder (upstream build process needs update) * Duplicate `src/gridstack.js` into `dist/gridstack.js` (upstream build process needs update) * Update demo html to point to `dist` instead of `src`
troolee
added a commit
that referenced
this pull request
Mar 21, 2015
Update bower.json main files to match "standards"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows use of bower.json main value in build tools that rely on the appropriate files being defined in this main array. It also points to the un-minified, compiled versions as per bower spec:
https://github.com/bower/bower.json-spec#main
This brings the main value in line with other popular libraries such as jQuery/Bootstrap/Angular for use with tools such as wiredep and main-bower-files (gulp tool)
Changes below:
gridstack.cssfile to the main files arraydistfolder (upstream build process needs update)src/gridstack.jsintodist/gridstack.js(upstream build process needs update)distinstead ofsrcWhatever process is used by troolee upstream for compiling the scss into css needs to be updated to ensure it deploys into the new location. The same process should also be updated to copy the
src/gridstack.jsintodist/gridstack.json build.