delete /dist files again #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2019 08:37
generated on the fly (merge comflict)
generated on the fly (merge comflict)
adumesny
commented
Mar 28, 2019
| @@ -8,7 +8,7 @@ | |||
| "url": "git+https://github.com/gridstack/gridstack.js.git" | |||
| }, | |||
| "scripts": { | |||
| "build": "grunt && doctoc ./README.md && doctoc ./doc/README.md && doctoc ./doc/CHANGES.md", | |||
| "build": "mkdir dist && grunt && doctoc ./README.md && doctoc ./doc/README.md && doctoc ./doc/CHANGES.md", | |||
There was a problem hiding this comment.
hey guys I believe this is blocking the pipeline as mkdir dist will give an error if folder is already there (and build seems to create it). I removed it a subsequent review (which hasn't been been merged yet (see #982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generated on the fly (merge comflict each time otherwise)
Description
forgot to delete these with last (lodash) removal.
Checklist
npm test)