fix(experiments): report partial snapshot success - #6936
Draft
ahdriel wants to merge 1 commit into
Draft
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Member
Author
|
cursor review |
ahdriel
marked this pull request as ready for review
September 10, 2026 22:12
ahdriel
marked this pull request as draft
September 10, 2026 22:13
Contributor
 |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a7dc543. Configure here.
ahdriel
marked this pull request as ready for review
September 10, 2026 22:24
ahdriel
marked this pull request as draft
September 11, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features and Changes
Now that we don't throw errors in case a single metric fails to be analyzed, we need to pass this state up (on main, we currently see the partial success and still consider the snapshot a failure, to keep the previous behavior, which is now being modified by this PR).
So a analysis and a snapshot now can have the status of
partialandpartial-successrespectively.Testing