api: Deprecate LoadBalancer.handleResolvedAddresses()#11623
Merged
Conversation
…h Duration" This reverts commit ab97045.
Contributor
Author
|
Below points have been addressed: javadoc for public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses)
javadoc for public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses)
|
| * single list if needed. | ||
| * | ||
| * <p>Implementations can choose to reject the given addresses by returning {@code false}. | ||
| * <p>Implementations can choose to reject the given addresses by returning {@code UNAVAILABLE}. |
Contributor
There was a problem hiding this comment.
Replace with {@code Status.UNAVAILABLE} . Also below.
…d and related changes
We want to keep the old behavior until the old usages are removed.
Any old implementations that still implement handleResolvedAddresses() will have their implementationed "skipped" by new callers of acceptResolvedAddresses(). We've been having such forwarders implement both methods instead. Since there's very few usages of handleResolvedAddresses() left, out-of-tree implementations should generally be fine just swapping to acceptResolvedAddresses.
It should have been completely deleted if the method was being deleted. In this case, since I've restored the method we just need Deprecated on the test.
ejona86
approved these changes
Mar 23, 2026
Member
ejona86
left a comment
There was a problem hiding this comment.
@shivaspeaks, you can see now how the change is basically just the deprecation annotation and the one ClusterImplLoadBalancer fix. My best guess for why ClusterImplLoadBalancer wasn't already migrated is because we might have been in the middle of L74 and didn't want to do any unnecessary changes that would conflict.
Member
|
Looks like the version of checkstyle we use on Java 11+ fails to detect Javadoc |
shivaspeaks
approved these changes
Mar 25, 2026
Member
|
I changed the title and then I saw you already changed the description saying the deprecation of its companion.. |
kannanjgithub
pushed a commit
to kannanjgithub/grpc-java
that referenced
this pull request
May 4, 2026
Also deprecate its companion canHandleEmptyAddressListFromNameResolution(). Also fixup the Javadoc to align with the arguments/return values, so that people would have a better idea of how to use it. Fixes grpc#11194 --------- Co-authored-by: MV Shiva Prasad <[email protected]> Co-authored-by: Eric Anderson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also deprecate its companion canHandleEmptyAddressListFromNameResolution().
Also fixup the Javadoc to align with the arguments/return values, so that people
would have a better idea of how to use it.
Fixes #11194