This repository was archived by the owner on Apr 9, 2021. It is now read-only.
update node docs to use addService#776
Open
mitchdraft wants to merge 1 commit intogrpc:masterfrom
mitchdraft:docs-node-addservice-api
Open
update node docs to use addService#776mitchdraft wants to merge 1 commit intogrpc:masterfrom mitchdraft:docs-node-addservice-api
mitchdraft wants to merge 1 commit intogrpc:masterfrom
mitchdraft:docs-node-addservice-api
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Author
|
CLA signed |
carl-mastrangelo
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
Change seems fine, @murgatroid99 & @ZhouyihaiDing can you tell me if I should merge?
ZhouyihaiDing
approved these changes
Nov 13, 2018
|
The change seems fine to me too. @murgatroid99 can you please take a look? |
|
@murgatroid99 @nicolasnoble can you please rubber stamp, given that this is an example change it would be best if one of you looked over it. |
|
@murgatroid99 @nicolasnoble @hsaliak are we OK to merge this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small change to the docs now that the node server api has changed
link to api: https://github.com/grpc/grpc-node/blob/master/packages/grpc-native-core/src/server.js#L948
the examples work with or without this change, but the change removes this warning message: