Add function AddFields that allows setting zap fields without using tags. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ags. correct import
01fee58 to
a2505f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=========================================
+ Coverage 75.61% 76.42% +0.8%
=========================================
Files 34 34
Lines 1218 1247 +29
=========================================
+ Hits 921 953 +32
+ Misses 249 245 -4
- Partials 48 49 +1
Continue to review full report at Codecov.
|
|
Can you please add a symmetric function to the Logrus one then? :) |
|
@mwitkow - I added |
kindermoumoute
added a commit
to kindermoumoute/go-grpc-middleware
that referenced
this pull request
Dec 20, 2024
Support the similar helpers from the v1 introduced in grpc-ecosystem#91: - [ctxzap.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/zap/ctxzap/context.go#L23-L32) - [ctxlogrus.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/logrus/ctxlogrus/context.go#L22-L30) - [ctxkit.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/kit/ctxkit/context.go#L22-L28) Signed-off-by: Olivier Cano <[email protected]>
Merged
kindermoumoute
added a commit
to kindermoumoute/go-grpc-middleware
that referenced
this pull request
Dec 21, 2024
Support the similar helpers from the v1 introduced in grpc-ecosystem#91: - [ctxzap.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/zap/ctxzap/context.go#L23-L32) - [ctxlogrus.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/logrus/ctxlogrus/context.go#L22-L30) - [ctxkit.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/kit/ctxkit/context.go#L22-L28) Signed-off-by: Olivier Cano <[email protected]>
johanbrandhorst
added a commit
that referenced
this pull request
Dec 23, 2024
* logging: add AddFields Support the similar helpers from the v1 introduced in #91: - [ctxzap.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/zap/ctxzap/context.go#L23-L32) - [ctxlogrus.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/logrus/ctxlogrus/context.go#L22-L30) - [ctxkit.AddFields](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v1/logging/kit/ctxkit/context.go#L22-L28) Signed-off-by: Olivier Cano <[email protected]> * Update interceptors/logging/logging.go Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]> --------- Signed-off-by: Olivier Cano <[email protected]> Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting zap fields on the logger that persist. zap.fields ensure type safety on the fields.