Conversation
Add exclusive/shared file locking to the auth cache read-modify-write cycle to prevent data loss from concurrent writers. Uses a dedicated .lock file so the lock survives NamedTempFile::persist replacing the data file. - Use std::fs::File::lock()/lock_shared() (stabilized in Rust 1.89) - Separate lock file (.lock extension) per auth hash - Shared lock on reads, exclusive lock on writes - Lock acquisition failures are tolerated (best-effort cache) - Atomic write via NamedTempFile::persist with fallback to direct write - Add 9 unit tests covering save/load, corruption, clear, concurrent writes - Update MSRV to 1.89 (required for File::lock API) - Remove skip_serializing_if from Project/Domain for postcard compatibility - Move tempfile from dev-dependencies to dependencies (used in prod code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exclusive/shared file locking to the auth cache read-modify-write
cycle to prevent data loss from concurrent writers. Uses a dedicated
.lock file so the lock survives NamedTempFile::persist replacing the
data file.
writes
compatibility
code)