[DO NOT MERGE] AB Testing POC #13798
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 973 kB ℹ️ View Unchanged
|
cemms1
commented
Apr 16, 2025
There was a problem hiding this comment.
Initial draft of this file here: https://gist.github.com/cemms1/0d5c69d00b82eee1c0cdb609d345bf75
cemms1
commented
Apr 16, 2025
ab-testing/abTest.ts
Outdated
| /** Description of the AB test */ | ||
| description: string; | ||
| /** Email address of owner(s) of the test */ | ||
| owners: string[]; |
There was a problem hiding this comment.
TODO: Create owner definition as "team" type complete with name and email. Would like to be able to identify which team was running the AB test in the data lake
67b8c62 to
59ca921
Compare
59ca921 to
1674a26
Compare
|
Notes from 17/04/2025:
|
|
Notes from 24/04/2025:
|
Set up initial validation system for AB tests
Comment on lines
+9
to
+32
| name: 🦕 AB testing | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ab-testing/scripts | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # https://github.com/denoland/setup-deno#latest-stable-for-a-major | ||
| - uses: denoland/setup-deno@v1 | ||
| with: | ||
| deno-version: v2.2 | ||
|
|
||
| - name: Test | ||
| run: deno test | ||
|
|
||
| - name: Validate | ||
| run: deno run validate | ||
|
|
||
| # - name: Build | ||
| # run: deno run build | ||
|
|
||
| # - name: Deploy | ||
| # run: deno run deploy |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
To fix the issue, we will add a permissions block at the workflow level (root) to explicitly define the least privileges required. Since the workflow only involves testing and validation, it likely only needs contents: read permissions. This ensures that the workflow adheres to the principle of least privilege and avoids granting unnecessary write permissions.
Suggested changeset
1
.github/workflows/ab-testing.yml
| @@ -1,2 +1,4 @@ | ||
| name: 🦕 AB testing | ||
| permissions: | ||
| contents: read | ||
| on: |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.