Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

phated
Copy link
Member

@phated phated commented Mar 23, 2024

This is an alternative for #254 that relies on changes made in sparkles, glogg, and gulplog to listen & re-emit on the new global namespace.

Closes #249

TODO:

  • Add the message symbol to @gulpjs/messages package

@phated phated requested a review from sttk March 23, 2024 23:04
@phated phated marked this pull request as ready for review March 24, 2024 02:28
@phated
Copy link
Member Author

phated commented Mar 24, 2024

@sttk please review right away 🙏 This will be the last PR into gulp-cli before I release v3.0.0 and prepare gulp for the v5 release. Thank you for dedicating time!

Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated I've reviewed. Please take a look as there is one I pointed out.

@phated phated merged commit affeda9 into master Mar 24, 2024
@phated phated deleted the phated/gulplog-deprecated branch March 24, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider wiring gulplog v1 handlers and print deprecation warning when used.

2 participants