feat: add capability to generate TypeScript using protoc-gen-ts#376
Open
zamronypj wants to merge 1 commit intogunk:masterfrom
Open
feat: add capability to generate TypeScript using protoc-gen-ts#376zamronypj wants to merge 1 commit intogunk:masterfrom
zamronypj wants to merge 1 commit intogunk:masterfrom
Conversation
This commit adds capability to generate ESM TypeScript code using protoc-gen-ts NPM package and also edit readme file to explain different types of TypeScript generators and fix minor typo error.
maitungmn
reviewed
Feb 28, 2023
| Ts{ID: "ts_proto", ModuleName: "ts-proto", BinaryName : "protoc-gen-ts_proto"}, | ||
| Ts{ID: "ts_proto", ModuleName: "ts-proto", BinaryName: "protoc-gen-ts_proto"}, | ||
| //use npm protoc-gen-ts package | ||
| Ts{ID: "protoc-gen-ts", ModuleName: "protoc-gen-ts", BinaryName: "protoc-gen-ts"}, |
There was a problem hiding this comment.
Hi @zamronypj , just to make sure that BinaryName: "protoc-gen-ts" is different with line 75.
Contributor
Author
There was a problem hiding this comment.
@maitungmn they are different binaries although they have same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds capability to generate ESM TypeScript code using protoc-gen-ts NPM package and also edit readme file to explain different types of TypeScript generators and fix minor typo error.