Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ctabin
Copy link
Contributor

@ctabin ctabin commented Jul 16, 2023

Adds support for quotedNulls option in CSVREAD and CSVWRITE functions (see here) and reestablish previous behavior of CSV handling prior to 2.2.220.

This should fix the breaking change introduced by #3786 and extends its feature since with this PR the handling of the nullString in CSV can be more finely adjusted.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jul 16, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jul 16, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/h2database/h2database/3842.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/h2database/h2database/3842.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@ctabin ctabin force-pushed the csv-quoted-nulls branch from 31714db to df4e56c Compare July 17, 2023 08:01
Copy link
Contributor

@katzyn katzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please address comments below and send a license statement as described here
https://h2database.com/html/build.html#providing_patches
to our mailing list:
https://groups.google.com/g/h2-database
(This list is partially pre-moderated, some new messages may appear only after review.)

@ctabin ctabin force-pushed the csv-quoted-nulls branch from df4e56c to 78a2b4b Compare July 18, 2023 10:39
@ctabin
Copy link
Contributor Author

ctabin commented Jul 18, 2023

Hi @katzyn,

Thanks for the review, I think I handled all your feedbacks. Tell me if I need to change anything else.
Since I already contributed (see #2225), you should already have the license agreement.

@katzyn
Copy link
Contributor

katzyn commented Jul 18, 2023

Hi @katzyn,

Thanks for the review, I think I handled all your feedbacks. Tell me if I need to change anything else. Since I already contributed (see #2225), you should already have the license agreement.

I see. I was confused by First-time contributor label.

@ctabin ctabin force-pushed the csv-quoted-nulls branch from 78a2b4b to 9a0d1bb Compare July 18, 2023 13:54
@katzyn katzyn merged commit e493084 into h2database:master Jul 18, 2023
@ctabin
Copy link
Contributor Author

ctabin commented Jul 21, 2023

Hi @katzyn,
Since this PR fixes a breaking change in 2.2.220, would it be possible to have a minor release soon ?
Thanks for the merge.

@katzyn
Copy link
Contributor

katzyn commented Jul 21, 2023

I think we need to wait a few weeks more, maybe there are other not yet reported regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants