Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update NimBLERemoteCharacteristic.cpp #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

deepak4395
Copy link
Contributor

BLE itags don't return descriptor values so bypassing them to register notify callback function.

BLE itags don't return descriptor values so bypassing them to register notify callback function.
@chegewara
Copy link

This may work in your case, but not the other cases. You cant change library like that just for 1 case.

@h2zero
Copy link
Owner

h2zero commented Dec 1, 2020

Thanks for this but as @chegewara said this may cause problems with other uses.

However a change could be made to support this, I'll do some testing and get back to you.

Changed CONFIG_BT_NIMBLE_MAX_CONNECTIONS from 3 to 8
@deepak4395
Copy link
Contributor Author

This may work in your case, but not the other cases. You cant change library like that just for 1 case.

Can you please suggest a better way to do it?

@deepak4395
Copy link
Contributor Author

Thanks for this but as @chegewara said this may cause problems with other uses.

However a change could be made to support this, I'll do some testing and get back to you.
ohk

@h2zero
Copy link
Owner

h2zero commented Dec 18, 2020

Sorry, new github code review has an extra step now that I didn't notice, made comments days ago that didn't get posted.

@deepak4395 deepak4395 closed this Dec 24, 2020
@h2zero
Copy link
Owner

h2zero commented Dec 25, 2020

Not sure why you closed this? If you adjust the code as I suggested and let me know if it works for you I would merge it.

@h2zero
Copy link
Owner

h2zero commented Dec 25, 2020

@deepak4395 Since this was closed, I have pushed a new commit 8310b7b that will accommodate your use and credited you as the author. I hope this suits your needs. Please open another PR if it is insufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants