Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Farsi #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2017
Merged

Farsi #375

merged 3 commits into from
Mar 24, 2017

Conversation

Javid-Izadfar
Copy link
Contributor

I've add Farsi (Persian) translation of the document.

I'm really sorry about not following the rule of 'Just one Commit' thing ... but creating a bidirectional markdown proved to be a pain in the butt!

Copy link
Member

@appleboy appleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your format is different from origin README. Can you describe why change the format?

@Javid-Izadfar
Copy link
Contributor Author

As you may know, Farsi (like Arabic or Hebrew) is Right-to-Left.
Markdown dose not support rtl, but usually result is readable:

screen1

however, once you combine it with some English (or codes) it will mess everything up, including order of contents.
screen2
(top is messed up by common markup, bottom is fixed using HTML)

I hope it could demonstrate the reason why Farsi's format is different.

@ghaseminya
Copy link

Why Farsi directory not exist in Translation folder?

@appleboy appleboy merged commit a60f21e into h5bp:master Mar 24, 2017
@strugee
Copy link
Contributor

strugee commented Apr 5, 2017

@ghaseminya because no one had translated it to Farsi before this PR.

@ghaseminya
Copy link

@strugee yes, its merged,
thanks

MUDev1994 pushed a commit to MUDev1994/Front-end-Developer-Interview-Questions that referenced this pull request May 26, 2023
* Added Farsi Translation

* fixed bidirectional markdown

* fixed some markdown rendering issues on github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants