Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

takluyver
Copy link
Member

Apparently the way we were setting TOXPYTHON for all environments is not recommended by the tox devs, and is probably going to raise an error in a future version of tox.

This is an attempt at making and using a plugin tox-appveyor to select 32-bit or 64-bit Python builds on Appveyor.

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #1196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          18       18           
  Lines        2160     2160           
=======================================
  Hits         1810     1810           
  Misses        350      350

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830248a...f5526ec. Read the comment docs.

@takluyver takluyver changed the title WIP: use appveyor plugin for tox Use appveyor plugin for tox Apr 1, 2019
@takluyver
Copy link
Member Author

That seems to be working. The Appveyor tests take a long, long time when they can't use the cached build of HDF5.

I saw some warnings about missing executables on Travis, and figured out that tox was trying to run every configured Python interpreter to interpolate its site-packages dir into the config. So the later changes are working around that.

@takluyver
Copy link
Member Author

@aragilar - it looks like you've done most of the work for Appveyor. Could I ask you to review this? The motivation is that I think warnings we're currently triggering in tox are due to turn into errors in a future version.

@aragilar
Copy link
Member

aragilar commented Apr 6, 2019

This looks so much nicer now :) and yeah, appveyor is very slow. Thanks for chasing this up.

@aragilar aragilar merged commit d4f1169 into h5py:master Apr 6, 2019
@takluyver takluyver deleted the tox-appveyor branch April 6, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants