Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use spec.creationTime consistently for reply timestamps#207

Merged
f2c-ci-robot[bot] merged 2 commits intomainfrom
copilot/fix-reply-time-inconsistency
Jan 19, 2026
Merged

Use spec.creationTime consistently for reply timestamps#207
f2c-ci-robot[bot] merged 2 commits intomainfrom
copilot/fix-reply-time-inconsistency

Conversation

Copy link
Contributor

Copilot AI commented Jan 19, 2026 •
edited
Loading

Replies used metadata.creationTimestamp while comments used spec.creationTime. Since metadata.creationTimestamp doesn't necessarily represent the actual creation time, both should use spec.creationTime.

Changes:

  • Updated reply-item.ts line 122 to use reply?.spec.creationTime instead of reply?.metadata.creationTimestamp
// Before
.creationTime="${this.reply?.metadata.creationTimestamp ?? undefined}"

// After  
.creationTime="${this.reply?.spec.creationTime}"

This aligns replies with comments, which already use spec.creationTime.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • pkg.pr.new
    • Triggering command: /usr/local/bin/node node /usr/local/bin/pnpm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>回复的时间不正确</issue_title>
<issue_description>目前项目中回复采用的时间是 metadata. creationTimestamp

plugin-comment-widget/packages/comment-widget/src/reply-item.ts

Line 122 in bf6435b

.creationTime="${this.reply?.metadata.creationTimestamp ?? undefined}"

但评论采用的时间又是 spec. creationTime

plugin-comment-widget/packages/comment-widget/src/comment-item.ts

Line 120 in bf6435b

.creationTime="${this.comment?.spec.creationTime}"

应当使其保持一致，建议统一使用 spec. creationTime， metadata. creationTimestamp 并不一定代表真实的创建时间。</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 19, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 19, 2026
Copilot AI changed the title [WIP] Fix reply time inconsistency with comment time Use spec.creationTime consistently for reply timestamps Jan 19, 2026
Copilot AI requested a review from ruibaby January 19, 2026 05:23
ruibaby
ruibaby approved these changes Jan 19, 2026
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026
@ruibaby ruibaby marked this pull request as ready for review January 19, 2026 08:52
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2026
@f2c-ci-robot f2c-ci-robot bot merged commit 5d70109 into main Jan 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ruibaby ruibaby ruibaby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ruibaby ruibaby

Copilot code review Copilot

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

回复的时间不正确

2 participants

@ruibaby