Metamask update to accept both 24 and 44 byte salt + variable amount of rounds of salt #4601
+62
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of rounds of salt This replaces pull request hashcat#4591. metamaskMobile updated to also accept 44 byte salt as well as the existing 24 byte salt. It also accept future implementations with rounds different from the default 5000. Minimum 1000 and maximum 1000000 rounds are accepted. Extraction of hash from newer versions of metamask produce 44 byte salt. PoC can be tested by cracking known hashes, cracking the same hashes with rounds=5000 inserted and then with different rounds to see them fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces pull request #4591.
metamaskMobile updated to also accept 44 byte salt as well as the existing 24 byte salt. It also accept future implementations with rounds different from the default 5000. Minimum 1000 and maximum 1000000 rounds are accepted. Extraction of hash from newer versions of metamask produce 44 byte salt. PoC can be tested by cracking known hashes, cracking the same hashes with rounds=5000 inserted and then with different rounds to see them fail.